Support for arbitrary HTTP methods #1

New Issue

0xEAB · 2024-10-27T15:24:48Z

0xEAB commented

2024-10-27 15:24:48 +00:00

Currently, HTTP request methods are limited to a predefined number of verbs from the HttpMethod enum.

This has two problems:

https://www.php-fig.org/psr/psr-7/

While HTTP method names are typically all uppercase characters, HTTP
method names are case-sensitive and thus implementations SHOULD NOT
modify the given string.
It makes the library unusable for protocols that build upon HTTP but add their own verbs on top, e.g. WebDAV.

IMHO, the HTTP request method should be stored as a string.

Currently, HTTP request methods are limited to a predefined number of verbs from the [HttpMethod](https://git.andrewlalis.com/Handy-Http/primitives/src/commit/23c74f82bedf662d3d6f8f2aed159a270f5a782d/source/handy_http_primitives/request.d#L44) enum. This has two problems: - <https://www.php-fig.org/psr/psr-7/> > While HTTP method names are typically all uppercase characters, HTTP > method names are case-sensitive and thus implementations SHOULD NOT > modify the given string. - It makes the library unusable for protocols that build upon HTTP but add their own verbs on top, e.g. [WebDAV](https://datatracker.ietf.org/doc/html/rfc4918#page-35). IMHO, the HTTP request method should be stored as a string.

0xEAB commented

2024-10-27 15:52:53 +00:00

The HttpStatus enum, on the other hand, already contains WebDAV status codes, like
https://git.andrewlalis.com/Handy-Http/primitives/src/commit/23c74f82bedf662d3d6f8f2aed159a270f5a782d/source/handy_http_primitives/response.d#L81-L83
and AFAICT can be used in a way to allow arbitrary response codes as-is, thus doesn’t have this issue.

The `HttpStatus` enum, on the other hand, already contains WebDAV status codes, like <https://git.andrewlalis.com/Handy-Http/primitives/src/commit/23c74f82bedf662d3d6f8f2aed159a270f5a782d/source/handy_http_primitives/response.d#L81-L83> and AFAICT can be used in a way to allow arbitrary response codes as-is, thus doesn’t have this issue.

andrew commented

2024-10-28 14:09:26 +00:00

Yep, you're right; I'm changing the type to const string method;. But I will still provide enum HttpMethod : string as a convenience for common methods.

Yep, you're right; I'm changing the type to `const string method;`. But I will still provide `enum HttpMethod : string` as a convenience for common methods.

🎉 1

andrew closed this issue

2024-10-28 14:10:26 +00:00

andrew referenced this issue from a commit

2024-10-28 14:12:08 +00:00

Addressed issues #3 (client address) and #1 (HTTP methods as strings)

Sign in to join this conversation.