andrew
/
ulid-creator
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace synchronized keyword with ReentrantLock

This commit is contained in:
Fabio Lima 2024-01-02 18:33:00 -03:00
parent 733242f980
commit 5690b562f9
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/main/java/com/github/f4b6a3/ulid/UlidFactory.java
View File

@ -27,6 +27,7 @@ package com.github.f4b6a3.ulid;
import java.security.SecureRandom; import java.security.SecureRandom;
import java.util.Objects; import java.util.Objects;
import java.util.Random; import java.util.Random;
import java.util.concurrent.locks.ReentrantLock;
import java.util.function.IntFunction; import java.util.function.IntFunction;
import java.util.function.LongFunction; import java.util.function.LongFunction;
import java.util.function.LongSupplier; import java.util.function.LongSupplier;
@ -51,6 +52,7 @@ public final class UlidFactory {
private final LongSupplier timeFunction; private final LongSupplier timeFunction;
private final LongFunction<Ulid> ulidFunction; private final LongFunction<Ulid> ulidFunction;
private final ReentrantLock lock = new ReentrantLock();
// ****************************** // ******************************
// Constructors // Constructors
@ -220,8 +222,8 @@ public final class UlidFactory {
* *
* @return a ULID * @return a ULID
*/ */
public synchronized Ulid create() { public Ulid create() {
return this.ulidFunction.apply(timeFunction.getAsLong()); return create(timeFunction.getAsLong());
} }
/** /**
@ -231,8 +233,13 @@ public final class UlidFactory {
* 1970-01-01T00:00Z (UTC) * 1970-01-01T00:00Z (UTC)
* @return a ULID * @return a ULID
*/ */
public synchronized Ulid create(final long time) { public Ulid create(final long time) {
return this.ulidFunction.apply(time); lock.lock();
try {
return this.ulidFunction.apply(time);
} finally {
lock.unlock();
}
} }
// ****************************** // ******************************
@ -318,7 +325,7 @@ public final class UlidFactory {
} }
@Override @Override
public synchronized Ulid apply(final long time) { public Ulid apply(final long time) {
final long lastTime = lastUlid.getTime(); final long lastTime = lastUlid.getTime();