From 7666c0f4505312ed9eb973f7e8adec4d2cef94d2 Mon Sep 17 00:00:00 2001
From: andrewlalis <andrewlalisofficial@gmail.com>
Date: Sun, 21 Sep 2025 15:36:07 -0400
Subject: [PATCH] Updated category select and transaction edit page.

---
 web-app/src/components/CategorySelect.vue     |  45 ++---
 .../src/pages/forms/EditTransactionPage.vue   | 157 ++++++------------
 2 files changed, 78 insertions(+), 124 deletions(-)

diff --git a/web-app/src/components/CategorySelect.vue b/web-app/src/components/CategorySelect.vue
index 5417a1f..909aabf 100644
--- a/web-app/src/components/CategorySelect.vue
+++ b/web-app/src/components/CategorySelect.vue
@@ -1,18 +1,32 @@
 <script setup lang="ts">
 import { getSelectedProfile } from '@/api/profile'
 import { TransactionApiClient, type TransactionCategoryTree } from '@/api/transaction'
-import { onMounted, ref, type Ref } from 'vue'
+import { computed, onMounted, ref, watch, type Ref } from 'vue'
 import { useRoute } from 'vue-router'
+import VueSelect, { type Option } from 'vue3-select-component'
 
 const route = useRoute()
 const model = defineModel<number | null>({ required: true })
 defineProps<{ required?: boolean }>()
 defineEmits<{ categorySelected: [TransactionCategoryTree | null] }>()
 const categories: Ref<TransactionCategoryTree[]> = ref([])
+const selectedCategory: Ref<TransactionCategoryTree | null> = ref(null)
+const options: Ref<Option<TransactionCategoryTree>[]> = computed(() => {
+  return categories.value.map(c => {
+    return { label: c.name, value: c }
+  })
+})
 
-onMounted(() => {
+watch(model, (newValue) => {
+  selectedCategory.value = newValue === null ? null : getCategoryById(newValue)
+})
+
+onMounted(async () => {
   const api = new TransactionApiClient(getSelectedProfile(route))
-  api.getCategoriesFlattened().then((c) => (categories.value = c))
+  categories.value = await api.getCategoriesFlattened()
+  if (model.value !== null) {
+    selectedCategory.value = getCategoryById(model.value)
+  }
 })
 
 function getCategoryById(id: number): TransactionCategoryTree | null {
@@ -23,23 +37,10 @@ function getCategoryById(id: number): TransactionCategoryTree | null {
 }
 </script>
 <template>
-  <select
-    v-model="model"
-    @change="$emit('categorySelected', model === null ? null : getCategoryById(model))"
-  >
-    <option
-      v-for="category in categories"
-      :key="category.id"
-      :value="category.id"
-    >
-      {{ '&nbsp;'.repeat(4 * category.depth) + category.name }}
-    </option>
-    <option
-      v-if="required !== true"
-      :value="null"
-      :selected="model === null"
-    >
-      None
-    </option>
-  </select>
+  <VueSelect class="category-select" v-model="selectedCategory" :options="options" placeholder="Select a category"
+    @option-selected="model = selectedCategory?.id ?? null" @option-deselected="model = null">
+    <template #option="{ option }">
+      {{ '&nbsp;'.repeat(option.value.depth * 4) }} {{ option.label }}
+    </template>
+  </VueSelect>
 </template>
diff --git a/web-app/src/pages/forms/EditTransactionPage.vue b/web-app/src/pages/forms/EditTransactionPage.vue
index d9594b0..88dd7c7 100644
--- a/web-app/src/pages/forms/EditTransactionPage.vue
+++ b/web-app/src/pages/forms/EditTransactionPage.vue
@@ -45,7 +45,6 @@ const editing = computed(() => {
   return existingTransaction.value !== null || route.meta.title === 'Edit Transaction'
 })
 const formValid = computed(() => {
-  console.log('Computing if for is valid...')
   return (
     timestamp.value.length > 0 &&
     amount.value > 0 &&
@@ -56,17 +55,18 @@ const formValid = computed(() => {
   )
 })
 const unsavedEdits = computed(() => {
-  console.log('Computing if there are unsaved edits...')
+  console.log("Checking if there are unsaved edits...")
   if (!existingTransaction.value) return true
+  const tx = existingTransaction.value
   const tagsEqual =
-    tags.value.every((t) => existingTransaction.value?.tags.includes(t)) &&
-    existingTransaction.value.tags.every((t) => tags.value.includes(t))
+    tags.value.every((t) => tx.tags.includes(t)) &&
+    tx.tags.every((t) => tags.value.includes(t))
   let lineItemsEqual = false
-  if (lineItems.value.length === existingTransaction.value.lineItems.length) {
+  if (lineItems.value.length === tx.lineItems.length) {
     lineItemsEqual = true
     for (let i = 0; i < lineItems.value.length; i++) {
       const i1 = lineItems.value[i]
-      const i2 = existingTransaction.value.lineItems[i]
+      const i2 = tx.lineItems[i]
       if (
         i1.idx !== i2.idx ||
         i1.quantity !== i2.quantity ||
@@ -81,17 +81,37 @@ const unsavedEdits = computed(() => {
   }
   const attachmentsChanged =
     attachmentsToUpload.value.length > 0 || removedAttachmentIds.value.length > 0
+  const timestampChanged = new Date(timestamp.value).toISOString() !== tx.timestamp
+  const amountChanged = amount.value * Math.pow(10, currency.value?.fractionalDigits ?? 0) !== tx.amount
+  const currencyChanged = currency.value?.code !== tx.currency.code
+  const descriptionChanged = description.value !== tx.description
+  const vendorChanged = vendor.value?.id !== tx.vendor?.id
+  const categoryChanged = categoryId.value !== (tx.category?.id ?? null)
+  const creditedAccountChanged = creditedAccountId.value !== (tx.creditedAccount?.id ?? null)
+  const debitedAccountChanged = debitedAccountId.value !== (tx.debitedAccount?.id ?? null)
+  console.log(`
+    Timestamp changed: ${timestampChanged}
+    Amount changed:    ${amountChanged}
+    Currency changed:  ${currencyChanged}
+    Description changed: ${descriptionChanged}
+    Vendor changed: ${vendorChanged}
+    Category changed: ${categoryChanged}
+    Credited account changed: ${creditedAccountChanged}
+    Debited account changed: ${debitedAccountChanged}
+    Tags changed: ${!tagsEqual}
+    Line items changed: ${!lineItemsEqual}
+    Attachments changed: ${attachmentsChanged}
+  `)
 
   return (
-    new Date(timestamp.value).toISOString() !== existingTransaction.value.timestamp ||
-    amount.value * Math.pow(10, currency.value?.fractionalDigits ?? 0) !==
-      existingTransaction.value.amount ||
-    currency.value !== existingTransaction.value.currency ||
-    description.value !== existingTransaction.value.description ||
-    (vendor.value?.id ?? null) !== (existingTransaction.value.vendor?.id ?? null) ||
-    categoryId.value !== (existingTransaction.value.category?.id ?? null) ||
-    creditedAccountId.value !== (existingTransaction.value.creditedAccount?.id ?? null) ||
-    debitedAccountId.value !== (existingTransaction.value.debitedAccount?.id ?? null) ||
+    timestampChanged ||
+    amountChanged ||
+    currencyChanged ||
+    descriptionChanged ||
+    vendorChanged ||
+    categoryChanged ||
+    creditedAccountChanged ||
+    debitedAccountChanged ||
     !tagsEqual ||
     !lineItemsEqual ||
     attachmentsChanged
@@ -279,46 +299,20 @@ function getLocalDateTimeStringFromUTCTimestamp(timestamp: string) {
       <FormGroup>
         <!-- Basic properties -->
         <FormControl label="Timestamp">
-          <input
-            type="datetime-local"
-            v-model="timestamp"
-            step="1"
-            :disabled="loading"
-            style="min-width: 250px"
-          />
+          <input type="datetime-local" v-model="timestamp" step="1" :disabled="loading" style="min-width: 250px" />
         </FormControl>
         <FormControl label="Amount">
-          <input
-            type="number"
-            v-model="amount"
-            step="0.01"
-            min="0.01"
-            :disabled="loading"
-            style="max-width: 100px"
-          />
+          <input type="number" v-model="amount" step="0.01" min="0.01" :disabled="loading" style="max-width: 100px" />
         </FormControl>
         <FormControl label="Currency">
-          <select
-            v-model="currency"
-            :disabled="loading || availableCurrencies.length === 1"
-          >
-            <option
-              v-for="currency in availableCurrencies"
-              :key="currency.code"
-              :value="currency"
-            >
+          <select v-model="currency" :disabled="loading || availableCurrencies.length === 1">
+            <option v-for="currency in availableCurrencies" :key="currency.code" :value="currency">
               {{ currency.code }}
             </option>
           </select>
         </FormControl>
-        <FormControl
-          label="Description"
-          style="min-width: 200px"
-        >
-          <textarea
-            v-model="description"
-            :disabled="loading"
-          ></textarea>
+        <FormControl label="Description" style="min-width: 200px">
+          <textarea v-model="description" :disabled="loading"></textarea>
         </FormControl>
       </FormGroup>
 
@@ -335,30 +329,16 @@ function getLocalDateTimeStringFromUTCTimestamp(timestamp: string) {
       <FormGroup>
         <!-- Accounts -->
         <FormControl label="Credited Account">
-          <select
-            v-model="creditedAccountId"
-            :disabled="loading"
-          >
-            <option
-              v-for="account in availableAccounts"
-              :key="account.id"
-              :value="account.id"
-            >
+          <select v-model="creditedAccountId" :disabled="loading">
+            <option v-for="account in availableAccounts" :key="account.id" :value="account.id">
               {{ account.name }} ({{ account.numberSuffix }})
             </option>
             <option :value="null">None</option>
           </select>
         </FormControl>
         <FormControl label="Debited Account">
-          <select
-            v-model="debitedAccountId"
-            :disabled="loading"
-          >
-            <option
-              v-for="account in availableAccounts"
-              :key="account.id"
-              :value="account.id"
-            >
+          <select v-model="debitedAccountId" :disabled="loading">
+            <option v-for="account in availableAccounts" :key="account.id" :value="account.id">
               {{ account.name }} ({{ account.numberSuffix }})
             </option>
             <option :value="null">None</option>
@@ -366,44 +346,23 @@ function getLocalDateTimeStringFromUTCTimestamp(timestamp: string) {
         </FormControl>
       </FormGroup>
 
-      <LineItemsEditor
-        v-if="currency"
-        v-model="lineItems"
-        :currency="currency"
-        :transaction-amount="floatMoneyToInteger(amount, currency)"
-      />
+      <LineItemsEditor v-if="currency" v-model="lineItems" :currency="currency"
+        :transaction-amount="floatMoneyToInteger(amount, currency)" />
 
       <FormGroup>
         <!-- Tags -->
         <FormControl label="Tags">
           <div style="margin-top: 0.5rem; margin-bottom: 0.5rem">
-            <TagLabel
-              v-for="t in tags"
-              :key="t"
-              :tag="t"
-              deletable
-              @deleted="tags = tags.filter((tg) => tg !== t)"
-            />
+            <TagLabel v-for="t in tags" :key="t" :tag="t" deletable @deleted="tags = tags.filter((tg) => tg !== t)" />
           </div>
           <div>
             <select v-model="selectedTagToAdd">
-              <option
-                v-for="tag in availableTags"
-                :key="tag"
-                :value="tag"
-              >
+              <option v-for="tag in availableTags" :key="tag" :value="tag">
                 {{ tag }}
               </option>
             </select>
-            <input
-              v-model="customTagInput"
-              placeholder="Custom tag..."
-            />
-            <button
-              type="button"
-              @click="addTag()"
-              :disabled="selectedTagToAdd === null && !customTagInputValid"
-            >
+            <input v-model="customTagInput" placeholder="Custom tag..." />
+            <button type="button" @click="addTag()" :disabled="selectedTagToAdd === null && !customTagInputValid">
               Add Tag
             </button>
           </div>
@@ -412,18 +371,12 @@ function getLocalDateTimeStringFromUTCTimestamp(timestamp: string) {
 
       <FormGroup>
         <h5>Attachments</h5>
-        <FileSelector
-          :initial-files="existingTransaction?.attachments ?? []"
-          v-model:uploaded-files="attachmentsToUpload"
-          v-model:removed-files="removedAttachmentIds"
-        />
+        <FileSelector :initial-files="existingTransaction?.attachments ?? []"
+          v-model:uploaded-files="attachmentsToUpload" v-model:removed-files="removedAttachmentIds" />
       </FormGroup>
 
-      <FormActions
-        @cancel="doCancel()"
-        :disabled="loading || !formValid || !unsavedEdits"
-        :submit-text="editing ? 'Save' : 'Add'"
-      />
+      <FormActions @cancel="doCancel()" :disabled="loading || !formValid || !unsavedEdits"
+        :submit-text="editing ? 'Save' : 'Add'" />
     </AppForm>
   </AppPage>
 </template>