andrew
/
SpeedCarts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Minecraft 1.18 #4

Merged
ModProg merged 3 commits from 1.18 into 1.17 2021-12-03 13:44:25 +00:00
Conversation 4 Commits 3 Files Changed 9 +262 -213
ModProg commented 2021-12-01 17:00:26 +00:00 (Migrated from github.com)
Copy Link
No description provided.
andrewlalis (Migrated from github.com) reviewed 2021-12-01 17:00:26 +00:00
andrewlalis (Migrated from github.com) requested changes 2021-12-02 05:38:06 +00:00
andrewlalis (Migrated from github.com) left a comment
Copy Link

If you can fix the problem with the source files appearing as new files under a remappedSrc directory and any other issues I commented on, then I can merge this.

If you can fix the problem with the source files appearing as new files under a `remappedSrc` directory and any other issues I commented on, then I can merge this.
gradle.properties
andrewlalis (Migrated from github.com) commented 2021-12-02 05:37:09 +00:00
Copy Link

Fix indentation

Fix indentation
ModProg commented 2021-12-02 11:13:09 +00:00 (Migrated from github.com)
Copy Link

If you can fix the problem with the source files appearing as new files under a remappedSrc directory and any other issues I commented on, then I can merge this.

oh yeah of course I must have missed those when committing :D

> If you can fix the problem with the source files appearing as new files under a `remappedSrc` directory and any other issues I commented on, then I can merge this. oh yeah of course I must have missed those when committing :D
andrewlalis commented 2021-12-02 14:47:12 +00:00 (Migrated from github.com)
Copy Link

Looks like the Github action for gradle build is failing because the workflow hasn't been updated to build with java 17. Additionally, modid.mixins.json still has a compatibilityLevel set to JAVA_16. Maybe that should be updated as well?

Looks like the Github action for `gradle build` is failing because the workflow hasn't been updated to build with java 17. Additionally, `modid.mixins.json` still has a `compatibilityLevel` set to `JAVA_16`. Maybe that should be updated as well?
ModProg commented 2021-12-02 18:47:21 +00:00 (Migrated from github.com)
Copy Link

Additionally, modid.mixins.json still has a compatibilityLevel set to JAVA_16. Maybe that should be updated as well?

Does 1.18 only support 17?

> Additionally, `modid.mixins.json` still has a `compatibilityLevel` set to `JAVA_16`. Maybe that should be updated as well? Does 1.18 only support 17?
ModProg commented 2021-12-02 18:52:41 +00:00 (Migrated from github.com)
Copy Link

oh aparently they updated: https://www.pcgamesn.com/minecraft/1-18-pre-release-2

oh aparently they updated: https://www.pcgamesn.com/minecraft/1-18-pre-release-2
Sign in to join this conversation.
Reviewers
No reviewers
andrewlalis
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrew/SpeedCarts#4
No description provided.
Delete Branch "1.18"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?