andrew
/
SpeedCarts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Use standard SoundEvent instance for correct Registry behavior #2

Merged
magneticflux- merged 1 commits from 1.17 into 1.17 2021-08-06 11:16:51 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -2
magneticflux- commented 2021-08-06 09:57:35 +00:00 (Migrated from github.com)
Copy Link

Registries use object identity for hashing and comparison, so creating a new SoundEvent instance isn't guaranteed to return the same registry entry for network serialization, etc.

Closes #1

Registries use object identity for hashing and comparison, so creating a new `SoundEvent` instance isn't guaranteed to return the same registry entry for network serialization, etc. Closes #1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: andrew/SpeedCarts#2
No description provided.
Delete Branch "1.17"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?