1.19.3 broke the mod #11

New Issue

andrew · 2023-02-05T04:11:38Z

zndrmn commented

2023-02-05 04:11:38 +00:00

(Migrated from github.com)

If you need more info I can send logs and stuff if you're still active

andrewlalis commented

2023-02-05 16:06:24 +00:00

(Migrated from github.com)

I'm not really supporting this mod anymore; I think one of the other open issues links to a more up-to-date mod which is similar enough. However if it's a simple fix I could look at making a small update. Send the error message in any case.

zndrmn commented

2023-02-06 07:56:28 +00:00

(Migrated from github.com)

if (this.hasPlayerRider()) {
	PlayerEntity player = (PlayerEntity) this.getFirstPassenger();
	if (player != null) {
		player.playSound(SoundEvents.BLOCK_NOTE_BLOCK_BELL, SoundCategory.PLAYERS, 1.0f, 1.0f);
	}

I did some digging and SoundEvents.BLOCK_NOTE_BLOCK_BELL is what's causing the mod to crash
changing it to anything under SoundEvents fixes it.

I used SoundEvents.BLOCK_REDSTONE_TORCH_BURNOUT with the volume at 0.15f which imo is the best alternative to the note block sound.
I can make a PR if you want but I feel like it would be better to just outright fix the noteblock sound rather than using a workaround

I checked out the mod linked in one of the open issues and you can't change the speed of the minecart manually like with this mod

```java if (this.hasPlayerRider()) { PlayerEntity player = (PlayerEntity) this.getFirstPassenger(); if (player != null) { player.playSound(SoundEvents.BLOCK_NOTE_BLOCK_BELL, SoundCategory.PLAYERS, 1.0f, 1.0f); } ``` I did some digging and `SoundEvents.BLOCK_NOTE_BLOCK_BELL` is what's causing the mod to crash changing it to anything under `SoundEvents` fixes it. I used `SoundEvents.BLOCK_REDSTONE_TORCH_BURNOUT` with the volume at `0.15f` which imo is the best alternative to the note block sound. I can make a PR if you want but I feel like it would be better to just outright fix the noteblock sound rather than using a workaround I checked out the mod linked in one of the open issues and you can't change the speed of the minecart manually like with this mod

andrewlalis commented

2023-02-06 12:32:55 +00:00

(Migrated from github.com)

Alright; I'll take a look this evening.

Nicolol1234 commented

2023-07-17 17:32:55 +00:00

(Migrated from github.com)

any news?

zndrmn commented

2023-07-17 19:13:53 +00:00

(Migrated from github.com)

Working 1.20 port
https://github.com/nagata-yoshiteru/SpeedCarts