andrew
/
SpeedCarts
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Use standard `SoundEvent` instance for correct `Registry` behavior 

Registries use object identity for hashing and comparison, so creating a new `SoundEvent` instance isn't guaranteed to return the same registry entry for network serialization, etc.

Closes #1
This commit is contained in:
Mitchell Skaggs 2021-08-06 04:57:02 -05:00
parent 874ed7fdd1
commit ead447789c
No known key found for this signature in database
GPG Key ID: 4EB0FECB84AE8967
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/nl/andrewlalis/speed_carts/mixin/AbstractMinecartMixin.java
View File

@ -14,7 +14,7 @@ import net.minecraft.entity.MovementType;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.entity.vehicle.AbstractMinecartEntity;
import net.minecraft.sound.SoundCategory;
import net.minecraft.sound.SoundEvent;
import net.minecraft.sound.SoundEvents;
import net.minecraft.state.property.Properties;
import net.minecraft.text.Text;
import net.minecraft.util.DyeColor;
@ -156,7 +156,7 @@ public abstract class AbstractMinecartMixin extends Entity {
if (this.hasPlayerRider()) {
PlayerEntity player = (PlayerEntity) this.getFirstPassenger();
if (player != null) {
player.playSound(new SoundEvent(new Identifier("block.note_block.bell")), SoundCategory.PLAYERS, 1.0f, 1.0f);
player.playSound(SoundEvents.BLOCK_NOTE_BLOCK_BELL, SoundCategory.PLAYERS, 1.0f, 1.0f);
}
}
return true;