From cac3381c54574e85f0cdcd90b8f36fa111ef807b Mon Sep 17 00:00:00 2001
From: Andrew Lalis <andrewlalisofficial@gmail.com>
Date: Mon, 8 Feb 2021 18:08:10 +0100
Subject: [PATCH] Fixed bugs in attribute adding action and saving.

---
 .../control/actions/edits/AddAttributeAction.java  | 14 ++++++++++----
 .../java/nl/andrewlalis/erme/model/Attribute.java  |  2 +-
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/src/main/java/nl/andrewlalis/erme/control/actions/edits/AddAttributeAction.java b/src/main/java/nl/andrewlalis/erme/control/actions/edits/AddAttributeAction.java
index 053b138..9cef6fb 100644
--- a/src/main/java/nl/andrewlalis/erme/control/actions/edits/AddAttributeAction.java
+++ b/src/main/java/nl/andrewlalis/erme/control/actions/edits/AddAttributeAction.java
@@ -56,6 +56,7 @@ public class AddAttributeAction extends AbstractAction {
 				Stream.iterate(0, n -> n + 1).limit(r.getAttributes().size() + 1).toArray(),
 				r.getAttributes().size()
 		);
+		if (index == null) return;
 		AttributeType type = (AttributeType) JOptionPane.showInputDialog(
 				c,
 				"Select the type this attribute is.",
@@ -65,12 +66,16 @@ public class AddAttributeAction extends AbstractAction {
 				AttributeType.values(),
 				AttributeType.PLAIN
 		);
-		boolean shouldUseForeignKey = JOptionPane.showConfirmDialog(
+		if (type == null) return;
+		boolean shouldUseForeignKey = ((String) JOptionPane.showInputDialog(
 				c,
 				"Is this attribute a foreign key?",
 				"Foreign Key",
-				JOptionPane.YES_NO_OPTION
-		) == JOptionPane.YES_OPTION;
+				JOptionPane.PLAIN_MESSAGE,
+				null,
+				new String[]{"Yes", "No"},
+				"No"
+		)).equalsIgnoreCase("yes");
 		if (shouldUseForeignKey) {
 			if (this.model.getRelations().size() < 2) {
 				JOptionPane.showMessageDialog(c, "There should be at least 2 relations present in the model.", "Not Enough Relations", JOptionPane.WARNING_MESSAGE);
@@ -85,7 +90,8 @@ public class AddAttributeAction extends AbstractAction {
 					this.model.getRelations().toArray(new Relation[0]),
 					this.model.getRelations().stream().findFirst().orElse(null)
 			);
-			List<Attribute> eligibleAttributes = fkRelation.getReferencableAttributes();
+			if (fkRelation == null) return;
+			List<Attribute> eligibleAttributes = fkRelation.getAttributes();
 			if (eligibleAttributes.isEmpty()) {
 				JOptionPane.showMessageDialog(c, "There are no referencable attributes in the selected relation.", "No Referencable Attributes", JOptionPane.WARNING_MESSAGE);
 				return;
diff --git a/src/main/java/nl/andrewlalis/erme/model/Attribute.java b/src/main/java/nl/andrewlalis/erme/model/Attribute.java
index 7edf049..a6ef1d3 100644
--- a/src/main/java/nl/andrewlalis/erme/model/Attribute.java
+++ b/src/main/java/nl/andrewlalis/erme/model/Attribute.java
@@ -15,7 +15,7 @@ public class Attribute implements Serializable {
 	private AttributeType type;
 	private String name;
 
-	private AttributeViewModel viewModel;
+	private transient AttributeViewModel viewModel;
 
 	public Attribute(Relation relation, AttributeType type, String name) {
 		this.relation = relation;